[openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment

Kirill Zaitsev kzaitsev at mirantis.com
Sun Jun 14 23:27:04 UTC 2015

Since there were no objections, and as a follow-up I’ve created a BP for that in murano: https://blueprints.launchpad.net/murano/+spec/add-shellcheck-jobs

Kirill Zaitsev
Murano team
Software Engineer
Mirantis, Inc

On 10 Jun 2015 at 18:07:19, Filip Blaha (filip.blaha at hp.com) wrote:

Thanks for comment and suggestion!  

there is also shutil2 framework for unit testing over shell scripts. We  
shall consider it whether it could bring us value for the effort. I  
personally have no strong opinion about that. Little contradiction to my  
previous mail:-)  


On 06/10/2015 03:34 PM, Jeremy Stanley wrote:  
> On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote:  
>> +1, nice idea. Shell script are not easy to review - large files, not  
>> covered by unit tests. Any automatic tool could be beneficial.  
> It's worth noting that just because your shell scripts don't have  
> their own validation tests doesn't mean they can't. For example see  
> the test-features.sh and test-functions.sh scripts in the  
> https://git.openstack.org/cgit/openstack-infra/devstack-gate/ repo,  
> making sure we maintain a contract on things like branch fallback  
> logic which is easy to subtly break if not tested.  

OpenStack Development Mailing List (not for usage questions)  
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150615/481d34e2/attachment.html>

More information about the OpenStack-dev mailing list