[openstack-dev] Please stop reviewing code while asking questions

Dean Troyer dtroyer at gmail.com
Fri Apr 24 21:40:07 UTC 2015

On Fri, Apr 24, 2015 at 2:00 PM, Julien Danjou <julien at danjou.info> wrote:

> I like that point and I agree with you. The problem, as someone already
> stated, is that these people are rarely on IRC and sometimes just never
> reply on the review. Right, maybe next time I'll chase them down via
> email. Sometimes I wish we were a little more conservative about who
> could do code review, but well.

After a bit of due diligence to track down the reviewer, make a note,
ignore that -1 and move on.  To address the fact that the -1 causes the
review to not appear in many people's dashboards, if that feels like an
issue, do a trivial patchset to actually reset the -1 if no other changes
are otherwise forthcoming.

I've been guilty of doing this (forgetting about a -1 on a review) and like
to think that I'd pass whatever bar was set for reviewers.  Limiting the
pool of reviewers really doesn't fix the problem and sets a bad tone for
the project. See all of the discussions about core status and exclusivity,
we don't need to inflict more of that on ourselves.



Dean Troyer
dtroyer at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150424/8fc22266/attachment.html>

More information about the OpenStack-dev mailing list