[openstack-dev] Please stop reviewing code while asking questions
ihrachys at redhat.com
Fri Apr 24 10:10:05 UTC 2015
-----BEGIN PGP SIGNED MESSAGE-----
On 04/24/2015 10:14 AM, Julien Danjou wrote:
> Hi there,
> This is now happening weekly to me now, probably because I write
> too many patches touching almost all OpenStack projects once a
> cycle, and I'm really tired of that behavior, so PLEASE:
> *Stop sending Code-Review-1 when asking a question in a patch*
> _Sometimes_ there are good reasons to set -1 even when asking a
> question. For example, when the question is a hint sent to the
> patch author so that (s)he improves is commit message, a code
> comment or a piece of code.
> But most of the time, if you ask a question because there's
> something YOU DO NOT KNOW OR UNDERSTAND, do not put a score to a
> patchset. You don't know the answer, so you have absolutely no
> right to evaluate a patchset with -1. Just don't set a score, it's
> OK, and wait for the answer before deciding if the patch is worth
> Thank you for listening, and happy hacking!
Generally +1. Neither reviewers should put -1 due to nitty nits for
typos in comments and especially in commit messages. There is a huge
price of it (we often note cpu cycles in this regard, but the actual
price is frustration and excessive attention to irrelevant "issues"
from fellow contributors). [Sometimes typos in comments and commit
messages really deserve -1, f.e. when they are not intelligible due to
those typos, but it's "one in a million" case.]
- From the other side, the problem with no score comments is that some
contributors assume those comments are not worth attention, since they
presumably don't influence the merge process.
And (almost) all comments are worth being answered. If not for the
particular patchset, if not for the author of the patch, then at least
for the reviewer.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
-----END PGP SIGNATURE-----
More information about the OpenStack-dev