[openstack-dev] Please stop reviewing code while asking questions

Fox, Kevin M Kevin.Fox at pnnl.gov
Fri Apr 24 13:22:47 UTC 2015

Ive seen this a lot too. It is frustrating.


From: Julien Danjou
Sent: Friday, April 24, 2015 1:14:38 AM
To: openstack-dev at lists.openstack.org
Subject: [openstack-dev] Please stop reviewing code while asking questions

Hi there,

This is now happening weekly to me now, probably because I write too
many patches touching almost all OpenStack projects once a cycle, and
I'm really tired of that behavior, so PLEASE:

  *Stop sending Code-Review-1 when asking a question in a patch*

_Sometimes_ there are good reasons to set -1 even when asking a
question. For example, when the question is a hint sent to the patch
author so that (s)he improves is commit message, a code comment or a
piece of code.

But most of the time, if you ask a question because there's something
YOU DO NOT KNOW OR UNDERSTAND, do not put a score to a patchset. You
don't know the answer, so you have absolutely no right to evaluate a
patchset with -1. Just don't set a score, it's OK, and wait for the
answer before deciding if the patch is worth [-1..+2].

Thank you for listening, and happy hacking!

Julien Danjou
;; Free Software hacker
;; http://julien.danjou.info
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150424/a8d97f6d/attachment.html>

More information about the OpenStack-dev mailing list