[openstack-dev] [oslo] graduating oslo.middleware

Doug Hellmann doug at doughellmann.com
Wed Jul 23 20:52:37 UTC 2014


On Jul 23, 2014, at 3:49 PM, Ben Nemec <openstack at nemebean.com> wrote:

> On 2014-07-23 13:25, gordon chung wrote:
> 
>> > I left a comment on one of the commits, but in general here are my thoughts:
>> > 1) I would prefer not to do things like switch to oslo.i18n outside of Gerrit.  I realize we don't have a specific existing policy for this, but doing that significant 
>> > work outside of Gerrit is not desirable IMHO.  It needs to happen either before graduation or after import into Gerrit.
>> > 2) I definitely don't want to be accepting "enable [hacking check]" changes outside Gerrit.  The github graduation step is _just_ to get the code in shape so it 
>> > can be imported with the tests passing.  It's perfectly acceptable to me to just ignore any hacking checks during this step and fix them in Gerrit where, again, 
>> > the changes can be reviewed.
>> > At a glance I don't see any problems with the changes that have been made, but I haven't looked that closely and I think it brings up some topics for 
>> > clarification in the graduation process.
>> 
>> 
>> i'm ok to revert if there are concerns. i just vaguely remember a reference in another oslo lib about waiting for i18n graduation but tbh i didn't actually check back to see what conclusion was.
>> 
>>  
>> cheers,
>> gord
> I have no specific concerns, but I don't want to set a precedent where we make a bunch of changes on Github and then import that code.  The work on Github should be limited to the minimum necessary to get the unit tests passing (basically if it's not listed in https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Manual_Fixes then it should happen in Gerrit).  Once that happens the project can be imported and any further changes made under our standard review process.  Either that or changes can be made in incubator before graduation and reviewed then.
> 
> So I guess I'm a soft -1 on this for right now, but I'll defer to the other Oslo cores because I don't really have time to take a more detailed look at the repo and I don't want to be a blocker when I may not be around to discuss it.
> 
> 

I agree with Ben on minimizing the amount of work that happens outside of the review process. I would have liked some discussion of the “remove stray tests”, for example.

Gordon, could you prepare a version of the repository that stops with the export and whatever changes are needed to make the test jobs for the new library run? If removing some of those tests is part of making the suite run, we can talk about that on the list here, but if you can make the job run without that commit we should review it in gerrit after the repository is imported.

Doug

> -Ben
> 
>  
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140723/e5ff4099/attachment.html>


More information about the OpenStack-dev mailing list