<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jul 23, 2014, at 3:49 PM, Ben Nemec <<a href="mailto:openstack@nemebean.com">openstack@nemebean.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div style="font-size: 10pt; font-family: Verdana,Geneva,sans-serif"><p>On 2014-07-23 13:25, gordon chung wrote:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">
<div dir="ltr">> I left a comment on one of the commits, but in general here are my thoughts:<br>> 1) I would prefer not to do things like switch to oslo.i18n outside of Gerrit. I realize we don't have a specific existing policy for this, but doing that significant <br><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>work outside of Gerrit is not desirable IMHO. It needs to happen either before graduation or after import into Gerrit.<br><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>2) I definitely don't want to be accepting "enable [hacking check]" changes outside Gerrit. The github graduation step is _just_ to get the code in shape so it <br><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>can be imported with the tests passing. It's perfectly acceptable to me to just ignore any hacking checks during this step and fix them in Gerrit where, again, <br><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>the changes can be reviewed.<br><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>At a glance I don't see any problems with the changes that have been made, but I haven't looked that closely and I think it brings up some topics for <br><span style="font-size: 12pt;">></span><span style="font-size: 12pt;"> </span>clarification in the graduation process.<br><br><br>i'm ok to revert if there are concerns. i just vaguely remember a reference in another oslo lib about waiting for i18n graduation but tbh i didn't actually check back to see what conclusion was.</div>
<div dir="ltr"><br>
<div> </div>
<span style="font-family: Calibri;">cheers,<br><em>gord</em></span></div>
</blockquote><p>I have no specific concerns, but I don't want to set a precedent where we make a bunch of changes on Github and then import that code. The work on Github should be limited to the minimum necessary to get the unit tests passing (basically if it's not listed in <a href="https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Manual_Fixes">https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Manual_Fixes</a> then it should happen in Gerrit). Once that happens the project can be imported and any further changes made under our standard review process. Either that or changes can be made in incubator before graduation and reviewed then.</p><p>So I guess I'm a soft -1 on this for right now, but I'll defer to the other Oslo cores because I don't really have time to take a more detailed look at the repo and I don't want to be a blocker when I may not be around to discuss it.</p><div><br></div></div></blockquote><div><br></div>I agree with Ben on minimizing the amount of work that happens outside of the review process. I would have liked some discussion of the “remove stray tests”, for example.</div><div><br></div><div>Gordon, could you prepare a version of the repository that stops with the export and whatever changes are needed to make the test jobs for the new library run? If removing some of those tests is part of making the suite run, we can talk about that on the list here, but if you can make the job run without that commit we should review it in gerrit after the repository is imported.</div><div><br></div><div>Doug</div><div><br><blockquote type="cite"><div style="font-size: 10pt; font-family: Verdana,Geneva,sans-serif"><p>-Ben</p>
<div> </div>
</div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></body></html>