[openstack-dev] Fw: [Glance] Is the 'killed' state ever set in v2?

Fei Long Wang flwang at cn.ibm.com
Sun Jan 26 10:56:25 UTC 2014


Hi David,

I think you're right. The 'killed' status should be set in method upload()
if there is an upload failure, see
https://github.com/openstack/glance/blob/master/glance/common/utils.py#L244

Thanks & Best regards,
Fei Long Wang (王飞龙)
---------------------------------------------------------------------
Tech Lead of Nitrogen (SME team)
Cloud Solutions and OpenStack Development
Tel: 8610-82450513 | T/L: 905-0513
Email: flwang at cn.ibm.com
China Systems & Technology Laboratory in Beijing
---------------------------------------------------------------------




------------------ Original ------------------
From:  "David Koo"<kpublicmail at gmail.com>;
Date:  Jan 26, 2014
To:  "OpenStack Development Mailing
List"<openstack-dev at lists.openstack.org>;
Subject:  [openstack-dev] [Glance] Is the 'killed' state ever set in v2?

Hi All,

While trying to work on a bug I was trying to simulate some image
download failures and found that apparently the 'killed' state is never
set using v2 APIs.

If I understand correctly, a file upload goes to
api.v2.image_data.ImageDataController.upload and goes all the way to
store.ImageProxy.set_data which proceeds to write to the backend store.

If the backend store raises an exception it is simply propagated all the
way up. The notifier re-encodes the exceptions (which is the bug I was
looking at) but doesn't do anything about the image status.

Nowhere does the image status seem to get set to 'killed'.

Before I log a bug I just wanted to confirm with everybody whether or
not I've missed out on something.

Thanks.

--
Koo

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev at lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140126/6f7f8d77/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140126/6f7f8d77/attachment.gif>


More information about the OpenStack-dev mailing list