[openstack-dev] [Hacking] unit test code is too less
yorik.sar at gmail.com
Thu Jan 23 07:45:03 UTC 2014
On Thu, Jan 23, 2014 at 6:47 AM, ZhiQiang Fan <aji.zqfan at gmail.com> wrote:
> I noticed that in openstack-dev/hacking project, there is very little test
> code, is there any particular reason why it is in such situation?
Yes, there is. Every rule have a docstring that not only provides examples
of good and bad code but also is run as a doctest here:
> it cannot detect
> \bprint >>>xxx, (\s+
I'm not sure how can it not detect the second one since the regular
expression used there to detect bad strings is "\bprint\s+[^\(]" and it
catches "print >>>xxx, (" string.
The first one is a good catch though.
If I want to improve this rule, how can I verify that my change is good?
Just change that regular expression as is needed and add a line to the
docstring like these:
Kind regards, Yuriy.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev