[openstack-dev] [Hacking] unit test code is too less

ZhiQiang Fan aji.zqfan at gmail.com
Thu Jan 23 02:47:58 UTC 2014


Hi,

I noticed that in openstack-dev/hacking project, there is very little test
code, is there any particular reason why it is in such situation?

since hacking module is depended by almost all openstack projects, I think
hacking code should be tested well at least

for i.e. the hacking rule h233 in hacking looks not so robust,
https://github.com/openstack-dev/hacking/blob/master/hacking/core.py#L345
it cannot detect

\bprint$
\bprint >>>xxx, (\s+

If I want to improve this rule, how can I verify that my change is good?

thanks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140123/1edc2cf5/attachment.html>


More information about the OpenStack-dev mailing list