[openstack-dev] Gerrit tools

Daniel P. Berrange berrange at redhat.com
Wed Oct 23 14:08:22 UTC 2013


On Sun, Oct 20, 2013 at 05:01:23AM +0000, Joshua Harlow wrote:
> I created some gerrit tools that I think others might find useful.
> 
> https://github.com/harlowja/gerrit_view
> 
> The neat one there is a curses based real time gerrit review receiver
> that uses a similar mechanism as the gerrit irc bot to sit on the
> gerrit event queue and receive events.

Actually, from my POV, the neat one there is the qgerrit script - I had
no idea you could query this info so easily. I've done some work on it
to allow you to filter based on project name, commit message string,
approval flags, and best of all, file path changed. I also improved the
date display to make it clearer how old patches are, which may help
people prioritize reviews for oldest stuff.

With this, I can now finally keep an eye on any change which impacts the
libvirt driver code:

eg to see all code touching 'nova/virt/libvirt', which has not been
-1'd by jenkins

$ qgerrit -f url -f subject:100 -f approvals -f lastUpdated -f createdOn -p openstack/nova -a v1 nova/virt/libvirt 
+------------------------------------+-----------------------------------------------------------------------+----------+----------+---------------------+
| URL                                | Subject                                                               | Created  | Updated  | Approvals           |
+------------------------------------+-----------------------------------------------------------------------+----------+----------+---------------------+
| https://review.openstack.org/33409 | Adding image multiple location support                                | 127 days | 17 hours | v=1 c=-1,1          |
| https://review.openstack.org/35303 | Stop, Rescue, and Delete should give guest a chance to shutdown       | 112 days | 2 hours  | v=1,1 c=-1          |
| https://review.openstack.org/35760 | Added monitor (e.g. CPU) to monitor and collect data                  | 110 days | 18 hours | v=1,1 c=-1,-1       |
| https://review.openstack.org/39929 | Port to oslo.messaging                                                | 82 days  | 7 hours  | v=1,1               |
| https://review.openstack.org/43984 | Call baselineCPU for full feature list                                | 56 days  | 1 day    | v=1,1 c=-1,1,1,1    |
| https://review.openstack.org/44359 | Wait for files to be accessible when migrating                        | 54 days  | 2 days   | v=1 c=1,1,1         |
| https://review.openstack.org/45993 | Remove multipath mapping device descriptor                            | 42 days  | 4 hours  | v=1,1 c=-1          |
| https://review.openstack.org/46055 | Remove dup of LibvirtISCSIVolumeDriver in LibvirtISERVolumeDriver     | 42 days  | 18 hours | v=1,1 c=2           |
| https://review.openstack.org/48246 | Disconnect from iSCSI volume sessions after live migration            | 28 days  | 5 days   | v=1                 |
| https://review.openstack.org/48362 | Fixing ephemeral disk creation.                                       | 27 days  | 16 hours | v=1,1 c=2           |
| https://review.openstack.org/49329 | Add unsafe flag to libvirt live migration call.                       | 21 days  | 6 days   | v=1,1 c=-1,-1,1,1,1 |
| https://review.openstack.org/50857 | Apply six for metaclass                                               | 13 days  | 6 hours  | v=1,1               |
| https://review.openstack.org/51193 | clean up numeric expressions with byte constants                      | 12 days  | 9 hours  | v=1                 |
| https://review.openstack.org/51282 | nova.exception does not have a ProcessExecutionError                  | 11 days  | 21 hours | v=1,1               |
| https://review.openstack.org/51287 | Remove vim header from from nova/virt                                 | 11 days  | 2 days   | v=1,1 c=-1,-1       |
| https://review.openstack.org/51718 | libvirt: Fix spurious backing file existence check.                   | 8 days   | 5 days   | v=1 c=1             |
| https://review.openstack.org/52184 | Reply with a meaningful exception, when libvirt connection is broken. | 6 days   | 16 hours | v=1,1 c=2           |
| https://review.openstack.org/52363 | Remove unnecessary steps for cold snapshots                           | 6 days   | 45 mins  | v=1,1 c=-1          |
| https://review.openstack.org/52401 | make libvirt driver get_connection thread-safe                        | 5 days   | 3 hours  | v=1,1               |
| https://review.openstack.org/52581 | Add context as parameter for resume                                   | 5 days   | 2 days   | v=1,1,1 c=1,1       |
| https://review.openstack.org/52777 | Optimize libvirt live migration workflow at source                    | 3 days   | 1 day    | v=1,1               |
| https://review.openstack.org/52807 | Create image again when resize revert a VM with image type as LVM     | 3 days   | 3 days   | v=1,1               |
| https://review.openstack.org/53069 | Fix lxc rootfs attached two devices in some action                    | 1 day    | 1 day    | v=1,1               |
+------------------------------------+-----------------------------------------------------------------------+----------+----------+---------------------+

> So no longer will u web browser haters (and console lovers) have to refresh to see changes. Haha.
> 
> Hopefully it works for u guys :)
> 
> Pull requests welcome too :)

Incoming... :-)

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



More information about the OpenStack-dev mailing list