[openstack-dev] [Metrics] Keeping up with review requests

Russell Bryant rbryant at redhat.com
Wed May 29 17:56:31 UTC 2013


On 05/29/2013 01:01 PM, Russell Bryant wrote:
> On 05/29/2013 08:17 AM, Christopher Yeoh wrote:
>> There does appear to be a problem with some of the data returned from
>> the gerrit query now however. For example,
>> looking at  https://review.openstack.org/29005 sometimes the createdOn
>> data for a patchset is just plain wrong and
>> reverts to the original creation date which makes it look like the it
>> hasn't been reviewed for a long time when it has.
>> I had a look at the origin json data returned from the query and it is
>> incorrect so I guess there's a gerrit query bug.
>>
> 
> Ah, I see what's happening.  The script uses createdOn of the latest
> patch set.  That's the timestamp of when it was written, not posted.
> The timestamp we want is in the gerrit UI, but not this data, as far as
> I can tell.
> 
> This is indeed throwing the times for some reviews *way* off.  I'm not
> sure of the best way to fix this, yet.

"fixed" ... or at least worked around.

https://github.com/russellb/openstack-stats/commit/1698e9d4d0c96072972474a8015d9f6b6f8cbc9f

-- 
Russell Bryant



More information about the OpenStack-dev mailing list