[openstack-dev] Code review study

Jay Buffington me at jaybuff.com
Tue Aug 20 15:37:05 UTC 2013

On Tue, Aug 20, 2013 at 8:02 AM, Mark McLoughlin <markmc at redhat.com> wrote:

> On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote:
> The full study is here:
> >
> >
> http://support.smartbear.com/resources/cc/book/code-review-cisco-case-study.pdf

I can't find the data they based their numbers on, nor their definition for
a line of code, so I feel like I have to take that study with a grain of

> We should not enforce rules like this blindly.

 I agree with the sentiment: less complex patches are easier to review.
 Reviewers should use their judgement and push back on complex patches to
be split up.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130820/2a792086/attachment.html>

More information about the OpenStack-dev mailing list