<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 20, 2013 at 8:02 AM, Mark McLoughlin <span dir="ltr"><<a href="mailto:markmc@redhat.com" target="_blank">markmc@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote:</div>
</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im"><span style="font-family:arial,sans-serif;font-size:12.800000190734863px">> The full study is here:</span><br style="font-family:arial,sans-serif;font-size:12.800000190734863px">
<span style="font-family:arial,sans-serif;font-size:12.800000190734863px">></span><br style="font-family:arial,sans-serif;font-size:12.800000190734863px"><span style="font-family:arial,sans-serif;font-size:12.800000190734863px">> </span><a href="http://support.smartbear.com/resources/cc/book/code-review-cisco-case-study.pdf" target="_blank" style="font-family:arial,sans-serif;font-size:12.800000190734863px">http://support.smartbear.com/resources/cc/book/code-review-cisco-case-study.pdf</a><br>
</div></blockquote><div><br></div><div>I can't find the data they based their numbers on, nor their definition for a line of code, so I feel like I have to take that study with a grain of salt.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

We should not enforce rules like this blindly.</blockquote><div><br></div><div> I agree with the sentiment: less complex patches are easier to review.  Reviewers should use their judgement and push back on complex patches to be split up.</div>
<div><br></div><div>Jay</div><div><br></div></div></div></div>