[openstack-dev] devstack modifying git repository

Monty Taylor mordred at inaugust.com
Tue Aug 6 13:18:42 UTC 2013

Hey Chmouel!

Good point. I think we could add a check to see if there are any changes
in the repo and skip the update if there are not. Or, we could protect
that action in a variable and have devstack-gate set that variable...
what do you guys think?

On 08/06/2013 12:56 AM, Chmouel Boudjnah wrote:
> Hello,
> I just saw that
> https://github.com/openstack-dev/devstack/commit/6c84463071e1ff23e20e4ef4fb863aba0732bebc
> as just landed.
> I understand the good reasons for that and thanks for the works that
> has been done into it but this has come to  some weird side effects of
> having devstack modifying your source tree when running it.
> My workflow when working on a feature/bug and I suspect I am not the
> only one is usually, run devstack, hack the source, unittests,
> unstack.sh/stack.sh run the devstack again etc.....
> When I commit those I would be commited that updated requirements, is
> it the side effect we want to force, should the commiter commit those
> or remove them before git-review it ? This seems to me some extra
> works for commiters/reviewers.
> Chmouel

More information about the OpenStack-dev mailing list