[openstack-dev] devstack modifying git repository
chmouel at enovance.com
Tue Aug 6 13:43:50 UTC 2013
On Tue, Aug 6, 2013 at 3:18 PM, Monty Taylor <mordred at inaugust.com> wrote:
> Good point. I think we could add a check to see if there are any changes
> in the repo and skip the update if there are not. Or, we could protect
> that action in a variable and have devstack-gate set that variable...
> what do you guys think?
I think most of the times, trying to modifiy automaticaly a user/dev
source code is recipes for problems.
Why don't we fo that it only when devstack is run in `gating mode` ?
PS: Apologies if this has been discussed earlier as I didn't follow
the full threads about this.
> On 08/06/2013 12:56 AM, Chmouel Boudjnah wrote:
>> I just saw that
>> as just landed.
>> I understand the good reasons for that and thanks for the works that
>> has been done into it but this has come to some weird side effects of
>> having devstack modifying your source tree when running it.
>> My workflow when working on a feature/bug and I suspect I am not the
>> only one is usually, run devstack, hack the source, unittests,
>> unstack.sh/stack.sh run the devstack again etc.....
>> When I commit those I would be commited that updated requirements, is
>> it the side effect we want to force, should the commiter commit those
>> or remove them before git-review it ? This seems to me some extra
>> works for commiters/reviewers.
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
More information about the OpenStack-dev