Open Stack

Sam Morrison wrote:
> 
> On 05/12/2012, at 10:35 AM, Joshua Harlow <harlowja at yahoo-inc.com> wrote:
> 
>> Isn't this also a code-review quality problem?
> 
> I agree.

Code review alone won't protect you from that. You need at the very
minimum a test to catch when the issue passes code review, and at best
automation to do the right thing automatically. We used to have a test
(back in bzr days), and we lost it when we moved to git. When I asked
for it to be back, it was suggested that automation was the right
answer, and it was done using setuptools_git.

> Also if the setuptools_git is just including all the files in the git repo then couldn't we just do that with a recursive include in the MANIFEST.in file instead.

A pure recursive include would include extra files that you don't
necessarily want in the resulting tarball. Not a specialist of
setuptools_git, but it looks like it takes the pure git repo content by
default, and applies extra excludes and includes from MANIFEST.in (and
.gitignore). Not saying that can't be emulated somehow, just saying it's
not as simple as it looks.

-- 
Thierry Carrez (ttx)
Release Manager, OpenStack