Open Stack

On 05/12/2012, at 10:35 AM, Joshua Harlow <harlowja at yahoo-inc.com> wrote:

> Isn't this also a code-review quality problem?

I agree.

Also if the setuptools_git is just including all the files in the git repo then couldn't we just do that with a recursive include in the MANIFEST.in file instead.
Would just need to catch all the file types, that could possibly be done at the gerrit stage automatically?

Currently when I build our debs I have this crazy script to generate a MANIFEST.in file then make a debian patch for it to apply at build time. 

Sam



> 
> On 12/4/12 9:29 AM, "Monty Taylor" <mordred at inaugust.com> wrote:
> 
>> ttx is right, we did this INSTEAD of a job that did a tarball build and
>> then compared the results of the tarball with the tree. You might think
>> that people should care when they add stuff, but you'd be amazed at how
>> wrong you would be.
>> 
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev