[Openstack-stable-maint] Approval procedure

Ihar Hrachyshka ihrachys at redhat.com
Tue Jul 22 11:37:06 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,
I'm walking thru the list of stable backports for Neutron, and I've
found an instance when a patch was pushed to gate by its author (or
better, backporter) without receiving any feedback from other team
members.

Let me remind you that (quoting [1]):

"Each backported commit proposed to gerrit should be reviewed and +2ed
by two stable-maint members before it is approved. Where a
stable-maint member has backported a fix, a single other +2 is
sufficient for approval."

So please refrain from pushing patches before another maintainer
checks your backport. Without following that rule, we miss opportunity
for peer review.

[1]: https://wiki.openstack.org/wiki/StableBranch#Gerrit

Cheers,
/Ihar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTzkziAAoJEC5aWaUY1u57yiEH/jc21KWveS4TUNkuFOJrSwfb
cNjCW3c0QoRWDt4oyJ4edcqu6snwCkXOOpSGEsrprf3v/sqKsPhNQvyMGPKUSL6a
QCrYXZFIx1WRFcR04a3zqLDWcuu3dUqz0BdJ38zoQTBOsvWJrtuuqdoTs0K/Niw7
bPEleyFO9MWW1FUt4wSb1GCK5KEkDzvGiY+poVk8p5CPbpJS8msIe8j6BNQFywDx
7OhyHA6IAQsiQANETvIF3ooVA2I/6jqtvaysI+qbh4qHuvUgRABcdOwh9mdG+rRd
cs7bIjrU9+1hSfCMJbv1+d4O9I+VV3N1WZ2W0Yy57sS8kdvt7hbJIec+/s8y2f4=
=NEGm
-----END PGP SIGNATURE-----



More information about the Openstack-stable-maint mailing list