Open Stack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 05/08/14 09:07, Alan Pevec wrote:
> 2014-08-04 15:24 GMT+02:00 Kyle Mestery <mestery at mestery.com>:
>> +1, getting this into merged would be very beneficial to our
>> users.
> 
> I've asked in backport review, repeating here: are there known 3rd
> party Neutron plugins which need to be made aware of this change? 
> Out-of-tree drivers are generally frowned upon but I'm not sure if 
> this is a part of documented plugin API?

This patch does not change default behaviour for
disassociate_floatingips() which is 'notify after db transaction'.
Plugins that are not in the tree may utilize the new optional
behaviour (do_notify=False) in case they also call the method from
under another transaction to avoid the issue, but those fixes belong
to those plugins, and the change proposed does not break them more
than the original code.

So we don't break third-party plugins, though we give them mechanism
to avoid specific db deadlock timeout in case it occurs in their code.

=> should be safe to backport.

/Ihar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJT4IeZAAoJEC5aWaUY1u574FYH/0UOnrDeSp8N5Y/R6Xv/gCZX
KneRjVsZeQWHoraE8xvSaTHMf/mKr7MKG25PCSF9vJzkLnF9dpzBSyYiu3A6LvkR
JpXbxqw4QLnki1YPhyUuFbd0VNDbFSJMVVoXPzAAj/cYfhDYw1zxj6KPWvwC96Ap
o/t5RRDURLlopi7NAhBKiyCChhZc3ddUMoCqpFOXlqq5VYqITNLADVf7q42ldpvc
sBj9V/u/HvCZwxQcfnkcxSLZeHWyAqMF6aEGj+duYJaAN+zCOY1A4UmDDYBukAVq
TGHlbG5YUFm4ZOlfpYobbGMpBDgsB0NFUefSt7UlVYF1jO8XauSNilTHNWYLpYg=
=vWWy
-----END PGP SIGNATURE-----