Open Stack

Reviewed:  https://review.opendev.org/679247
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=31773715687326c92d4ad46ebb32b14645bbc614
Submitter: Zuul
Branch:    master

commit 31773715687326c92d4ad46ebb32b14645bbc614
Author: Kobi Samoray <ksamoray at vmware.com>
Date:   Tue Aug 27 13:49:05 2019 +0300

    Avoid fetching metadata when no subnets found
    
    Metadata service uses the provider id to identify the requesting
    instance.
    However, when provider query doesn't find any networks, the request
    should fail.
    The same goes to the case where multiple ports are found.
    
    Closes-Bug: #1841933
    Change-Id: I8ce3703ca86a3a0769edd42a790d82796d1071d7


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of OpenStack
Security SIG, which is subscribed to OpenStack.
https://bugs.launchpad.net/bugs/1841933

Title:
  Fetching metadata via LB may result with wrong instance data

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Security Advisory:
  Won't Fix

Bug description:
  While querying metadata from an instance via a loadbalancer, metadata service relies on X-Metadata-Provider to identify the correct instance by querying Neutron for subnets which are attached to the loadbalancer.
  Then the subnet result is used to identify the instance by querying for ports which are attached to the subnets above.
  Yet, when the first query result is empty due to deletion, bug or any other reason within the Neutron side, this may cause a security vulnerability, as Neutron will retrieve ports of _any_ instance which has the same IP address as the instance which is queried.
  That could compromise key pairs and other sensitive data.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1841933/+subscriptions