[Openstack-security] [openstack/cinder] SecurityImpact review request change Id5f83f69fd3a877459fab924c005047e55f98c7b
gerrit2 at review.openstack.org
gerrit2 at review.openstack.org
Mon Sep 26 18:00:55 UTC 2016
Hi, I'd like you to take a look at this patch for potential
SecurityImpact.
https://review.openstack.org/376992
Log:
commit 96948e48b140a9a47d26bf805230df41a44c9c00
Author: Kaitlin Farr <kaitlin.farr at jhuapl.edu>
Date: Wed Sep 7 13:21:33 2016 -0400
Modifies override logic for key_manager
Makes the logic for overriding config options for the key_manager
more robust.
Before this patch, the override logic seemed to be called before the global
CONF object has been populated with values from the configuration file.
ConfKeyManager, the default for if no value had been specified, would be
used to override the value for api_class. Then when CONF was populated
with the actual values, the ConfKeyManager override value would still be
set.
This patch makes the logic a little bit more robust so that the value
is only overriden if explicitly passed into the function, not at the
global scope outside of the function.
SecurityImpact
Closes-Bug: 1621109
Change-Id: Id5f83f69fd3a877459fab924c005047e55f98c7b
(cherry picked from commit b66d4d997cf371d4d451aa9e57d351f4e045fc8d)
More information about the Openstack-security
mailing list