[Openstack-security] [openstack/swift] SecurityImpact review request change I1f629987fbc8c59406432faad9cb2bfa34b5eccc

gerrit2 at review.openstack.org gerrit2 at review.openstack.org
Fri Sep 25 13:48:49 UTC 2015


Hi, I'd like you to take a look at this patch for potential
SecurityImpact.
https://review.openstack.org/227855

Log:
commit 3b34655593bdbca976d9281008ca0cb8c64aeb10
Author: janonymous <janonymous.codevulture at gmail.com>
Date:   Fri Sep 25 19:13:28 2015 +0530

    Eventlet green threads not released back to pool
    
    Presently, the wsgi server allows persist connections hence even after
    the response is sent to the client, it doesn't close the client socket
    connection.
    Because of this problem, the green thread is not released back to the pool.
    
    In order to close the client socket connection explicitly after the
    response is sent and read successfully by the client, you simply have to
    set keepalive to False when you create a wsgi server.
    
    Add a parameter to take advantage of the new(ish) eventlet socket timeout
    behaviour. Allows closing idle client connections after a period of
    time.
    eg:
    $ time nc localhost 8776
    real 1m0.063s
    Setting 'client_socket_timeout = 0' means do not timeout.
    
    Added Parameters in Initial commit that needs to be changed as appropriate
    for swift configuration.
    
    DocImpact:
    Added wsgi_keep_alive option.
    Added client_socket_timeout option.
    
    SecurityImpact
    Closes-Bug: #1361360
    
    Change-Id: I1f629987fbc8c59406432faad9cb2bfa34b5eccc





More information about the Openstack-security mailing list