[Openstack-security] [openstack/nova] SecurityImpact review request change Ic529b1c2c1cfd914facb14941e4bb641db6a0e82

gerrit2 at review.openstack.org gerrit2 at review.openstack.org
Wed Feb 11 06:31:26 UTC 2015


Hi, I'd like you to take a look at this patch for potential
SecurityImpact.
https://review.openstack.org/154761

Log:
commit cefca3fadaa7cd41abe82c98094ddcd57d41254f
Author: Rajesh Tailor <rajesh.tailor at nttdata.com>
Date:   Thu Feb 5 02:57:59 2015 -0800

    Delete instance files from dest host in revert-resize
    
    When revert-resize call is finished, it doesn't clear instance
    files from destination node for non-shared instance storage.
    
    The driver call, which is responsible for destroying destination
    host instance is not deleting instance files, because it finds that
    both source and destination host shares the same instance storage.
    
    The check_instance_shared_storage rpc-call had no host information,
    hence the manager call for check_instance_shared_storage was checking
    instance storage on destination host itself and returning True even
    if it is non-shared storage.
    
    Added host parameter to check_instance_shared_storage rpc-call,
    so that in manager call check_instance_shared_storage method get
    executed on source compute node and returns True/False based on
    shared/non-shared storage.
    
    SecurityImpact
    
    Closes-Bug: #1418855
    Change-Id: Ic529b1c2c1cfd914facb14941e4bb641db6a0e82





More information about the Openstack-security mailing list