[Openstack-security] [Bug 1174499] Re: Keystone token hashing is MD5
Li Ma
skywalker.nick at gmail.com
Thu Aug 22 18:44:56 UTC 2013
I suggest to just change MD5 to SHA1. It's not that important to provide multiple choices of hash algorithms.
(1) The hash function is used internally and not exposed to end-users.
(2) A stable and secure hash algorithm can deal with the situation very well.
According to the security and performance, SHA1 is the promisinig trade-
off algorithm and it is also widely used in thousands of production-
ready systems.
--
You received this bug notification because you are a member of OpenStack
Security Group, which is subscribed to OpenStack.
https://bugs.launchpad.net/bugs/1174499
Title:
Keystone token hashing is MD5
Status in OpenStack Identity (Keystone):
In Progress
Bug description:
https://github.com/openstack/python-
keystoneclient/blob/master/keystoneclient/common/cms.py
def cms_hash_token(token_id):
"""
return: for ans1_token, returns the hash of the passed in token
otherwise, returns what it was passed in.
"""
if token_id is None:
return None
if is_ans1_token(token_id):
hasher = hashlib.md5()
hasher.update(token_id)
return hasher.hexdigest()
else:
return token_id
MD5 is a deprecated mechanism, it should be replaces with at least SHA1, if not SHA256.
Keystone should be able to support multiple Hash types, and the auth_token middleware should query Keystone to find out which type is in use.
To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1174499/+subscriptions
More information about the Openstack-security
mailing list