Open Stack

On 05/16/2013 03:44 PM, Jay Pipes wrote:
> No, we don't need all the below tags, and yes we need cleanup :)
> Comments inline on specific suggestions...
>
> On 05/16/2013 03:24 PM, Giampaolo Lauria wrote:
>> Hi,
>>
>> while working on
>> https://blueprints.launchpad.net/tempest/+spec/set-gate-attribute, I
>> decided to write a script to get a picture of what we currently have for
>> tags and attributes in our tests. Here is what I have found:
>>
>> Total tests found:  583
>>
>> Tag                                   Total # of instances
>> --------------------                  --------------------
>> 'NO TAG'                     226
>> EC2                                   6
>> S3                                    4
>> gate                                  20
>> live-migration                1
>
> Remove this.

+1

>> lp1170718                     1
>> lp912922                              2
>
> Remove these.

+1

>> nagative                              1
>> negative                              168
>> positive                              110
>
> I've never liked either the negative or positive categorization of
> tests. I don't see the point.

positive seems pointless, but negative seemed reasonable as a class of 
tests you could decide to exclude.

>> regression                    1
>
> Bad tag. Regression for what? Regressions are fixed over time, so this
> tag is a perfect example of something that just adds technical debt to
> the project.

+1

>> server-addresses              4
>
> Remove this.

+1

>> slow                                  1
>
> Slow when? Slow now? Slow at some point in the past? Always be slow?
> This is just technical debt.

So I know the test in question... it is really slow (it also is the 
first test that's currently run in tempest). It's the boto scenario test 
that actually sshes into the guest (but it does lots of other stuff as 
well).

slow could be a useful future tag, I'm ok currently dropping it.

>> smoke                                 82
>
> WAY too many things are tagged with smoke. All smoke tags should be
> removed, IMO, and the scenario tests should be considered the
> "acceptance" or "promotion" or "smoke" tests.

So that's kind of a good point. Once we get the restructure in, one of 
our goals is to ensure scenario >= devstack exercise scripts in value.

Once that is done, I think we can drop smoke.

Right now, smoke is still actively used in the gate for Quantum, as 
quantum can't pass full gate.

	-Sean

-- 
Sean Dague
http://dague.net