Open Stack

On 06/11/2013 04:47 PM, Matthew Treinish wrote:
> I've pushed out a WIP prototype of fixtures for images in the glance tests
> located here:
>
> https://review.openstack.org/#/c/32204/
>
> However I have a couple of concerns with the new model. The biggest one being
> how teardown works with fixtures. Currently in the images tests for teardown we
> loop over the list of created images and make a delete call on each of the images.
> Then after the loop exits we loop over the same list again and wait for the image
> to be removed. (not found on a GET) This has the advantage of doing all the async
> delete operations at once minimizing how long we wait. However, with fixtures this
> no longer works the same way. The clean ups for the image fixtures now run the
> delete immediately followed by the wait. This ends up giving us the worst case wait
> because none of the delete wait time ends up overlapping.
>
> This will be a big issue if we end up going down the fixtures route. We've
> already spent some time optimizing this type problem to try and minimize
> waiting. But, I'm not sure that the fixtures model allows to optimize the
> waiting on resource cleanup in the same way.
>
>
While I like the fixtures idea, I really don't think we want to enforce 
this kind of performance lossage. One
thought:

Add a Fixture.addTwoPhaseCleanup method that takes two "closures" 
instead of one, and tells the Fixture cleanup to do what we are doing 
right now
to cleanup efficiently.

  -David