[Openstack-operators] [log] LOG.exception should contain an exception message or not?
zioproto at gmail.com
Sat Jan 16 06:18:22 UTC 2016
I think the stacktrace is usefull when debugging, even as an operator.
Instead of changing the logs to satisfy the tools, it is the tools
that should be enable to parse the logs correctly.
2016-01-05 14:08 GMT+01:00 Akihiro Motoki <amotoki at gmail.com>:
> # cross-posting to -dev and -operators ML
> In the current most OpenStack implementation,
> when we use LOG.exception, we don't pass an exception message to LOG.exception:
> LOG.exception(_LE("Error while processing VIF ports"))
> IIUC it is because the exception message will be logged at the end of
> a corresponding stacktrace.
> We will get a line like (Full log: http://paste.openstack.org/show/483018/):
> ERROR ... Error while processing VIF ports
> Many logging tools are still line-oriented (though logstash or fluentd
> can handle multiple lines).
> An ERROR line only contains a summary message without the actual failure reason.
> This makes difficult for line-oriented logging tools to classify error logs.
> My proposal is to pass an exception message to LOG.exception like:
> except <some exception> as exc:
> LOG.exception(_LE("Error while processing VIF ports: %s"), exc)
> This alllows line-oriented logging tools to classify error logs more easily.
> OpenStack-operators mailing list
> OpenStack-operators at lists.openstack.org
More information about the OpenStack-operators