Open Stack

On Sat, May 21, 2016 at 7:18 PM, Wayne Warren <wayne at puppet.com> wrote:
> Howdy folks!
>
> About a year ago I announced my intent to put serious effort into
> improving JJB's Python API:
> http://lists.openstack.org/pipermail/openstack-infra/2015-May/002761.html
>
> The currently-approved spec can be seen here:
> https://specs.openstack.org/openstack-infra/infra-specs/specs/jenkins-job-builder_2.0.0-api-changes.html
>
> Related changes can be seen using the "jjb-2.0.0-api" Gerrit topic:
> https://review.openstack.org/#/q/topic:jjb-2.0.0-api

Probably everyone on this list is more gerrit-savvy than myself but
here is a better search link anyway (excludes all the abandoned
feature/2.0.0 branch changes):
https://review.openstack.org/#/q/project:openstack-infra/jenkins-job-builder+topic:jjb-2.0.0-api+status:open

>
> Last month after lots of hard work by the core JJB team the final
> "1.x" version (1.5.0) of JJB was released. Shoutout in particular to
> Darragh Bailey, who took on the most difficult role of keeping track
> of which patches were highest priority for 1.5.0, coordinating the
> necessary reviews, and managing the release--thanks!
>
> Now that JJB 1.5.0 is released, I have rebased the 19 commits in the
> jjb-2.0.0-api topic onto master branch and am about to push those up
> to gerrit for review. But first I wanted to send this email with next
> steps and some notes about my approach in refactoring the API.
>
> Notes about the refactor approach:
> * While there are a few necessarily large commits, most commits are
> small and single-purpose. The small single-purpose commits serve two
> purposes--they made it easier to incrementally change and test the API
> (I was reading a book called The Mikado Method at the time, it's
> definitely worth checking out); they should also make it easier to
> understand and review.
> * Because much of the work was split across 19 commits, I am
> anticipating there may be feedback on the earlier commits that is
> addressed in later commits--rather than shuffing changes around
> between commits or squashing the whole line into one uber-commit
> (+2170,-1411), I am hoping it will suffice for me to point out where
> this is the case to satisfy reviewers.
>
> Next steps:
> * Remove the feature/2.0.x branch from the jenkins-job-builder repo.
> * Review the patches!
> * Merge them when they're ready.
> * Write some API unit tests and documentation.
> * Release 2.0.0!
>
> Happy reviewing!