Open Stack

Thanks. Let me know if it makes sense for me to push those changes
upstream. I was not aware of the git credentials helper... I know
git-review is an infra project and thus not touched too much since everyone
uses it...

Best Regards,


On Wed, Feb 25, 2015 at 5:06 PM, Clark Boylan <cboylan at sapwetik.org> wrote:

> I see what you mean about defaulting the port now. I think having the
> port default to 443 when scheme is HTTPS would be a good improvement to
> git review. For password handling its probably best for users to use the
> git credential helper [0] instead of having git review try to be smart
> with that info. The nice thing about this method is that talking to the
> server with other git commands should just work as well.
>
> [0] http://git-scm.com/docs/gitcredentials
>
> On Wed, Feb 25, 2015, at 04:56 PM, Diego Garcia del Rio wrote:
> > This would be the page https://wiki.openstack.org/wiki/Gerrit_Workflow ,
> > in
> > particular the section called  "Accessing Gerrit over HTTPS"
> >
> > I think i still need to catch up on the automated infrastructure testing
> > as
> > well.
> >
> > Thanks!
> >
> >
> >
> >
> >
> >
> > On Wed, Feb 25, 2015 at 4:39 PM, Clark Boylan <cboylan at sapwetik.org>
> > wrote:
> >
> > > On Wed, Feb 25, 2015, at 04:23 PM, Diego Garcia del Rio wrote:
> > > > Hi,
> > > >
> > > > I'm pretty new to contributing code to openstack, but I had ran into
> some
> > > > issues trying to push changes to gerrit using the HTTPS option. (In
> > > > particular, added the ability to save your HTTP password into the git
> > > > config and  to automatically use port 443 if the scheme is HTTPS
> instead
> > > > of
> > > > the default SSH. I had a bit of head-banging to get the HTTPS working
> > > > (especially since the SSH port was still in place and not
> overridden). I
> > > > documented my steps on the wiki but thought that adding a bit more
> > > > intelligence to git-review would be useful for other new users or
> people
> > > > dealing with constrained connectivity options.
> > > >
> > > > should I submit my changes up to the openstack-infra/git-review?
> > > >
> > > Can you link to the wiki documentation? I think I need a bit more
> > > context before I can offer advice on pushing changes to git-review.
> > >
> > > Clark
> > >
> > > _______________________________________________
> > > OpenStack-Infra mailing list
> > > OpenStack-Infra at lists.openstack.org
> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
> > >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20150225/15bd43f3/attachment-0001.html>