[OpenStack-Infra] Feature suggestion: Style check failures inlined as comments
Erlon Cruz
sombrafam at gmail.com
Wed Feb 18 15:28:50 UTC 2015
I also don't think that will make the flow better. When you have errors on
any other gate checkers (python2.7, CI etc) you have to go to the logs
anyway. This would only add another place to look at.
One thing that would greatly improved gerrit interaction, would be a better
and cleaner way to display the comments. Mainly the one posted by CIs.
Take for instance this[1] thread, you have to digg among tons of anusefull
CIs messages to get what is important (people's reviews and comments).
Haven't happened any discussion about this yet?
[1] https://review.openstack.org/#/c/127455/
PS. From my phone browser the CI messages are not shown. Is it any
configuration of gerrit?
On 18 Feb 2015 09:12, "Chmouel Boudjnah" <chmouel at enovance.com> wrote:
> "Bruns, Curt E" <curt.e.bruns at intel.com> writes:
>
> > As a developer, to help speed up development, it would be beneficial
> > to have style check failures to be inserted as comments in code
> > reviews.
>
> I think to be honest it would even better if there was some Gerrit
> plugins that shows the error directly in the UI.
>
> (but that's wishful thinking :))
>
> IMHO, since the dev is going to have to need to fire his editor and
> fix the failure he should anyway run the tox -epep8 and see the full
> error first happening in the review. I am not sure that if it is in a
> gerrit
> comment it would make the flow better.
>
> Chmouel
>
>
>
> _______________________________________________
> OpenStack-Infra mailing list
> OpenStack-Infra at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20150218/35e2c113/attachment.html>
More information about the OpenStack-Infra
mailing list