Open Stack

On Mon, Jan 20, 2014 at 3:38 PM, Joe Gordon <joe.gordon0 at gmail.com> wrote:
> On Sun, Jan 19, 2014 at 7:01 AM, Monty Taylor <mordred at inaugust.com> wrote:
>> On 01/19/2014 05:38 AM, Sean Dague wrote:

>>> = Pep8 kick out of check =
>>>
>>> I think on the Check Queue we should pep8 first, and not run other tests
>>> until that passes (this reverses a previous opinion I had). We're now
>>> starving nodepool. Preventing taking 5 nodepool nodes on patches that
>>> don't pep8 would be handy. When Dan pushes a 15 patch change that fixes
>>> nova-network, and patch 4 has a pep8 error, we thrash a bunch.
>>
>>
>> Agree. I think this might be one of those things that goes back and forth
>> on being a good or bad idea over time. I think now is a time when it's a
>> good idea.
>
> What about adding a pre-gate queue that makes sure pep8 and unit tests pass
> before adding a job to the gate (of course this would mean we would have to
> re-run pep8 and unit tests in the gate). Hopefully this would reduce the
> amount of gate thrashing incurred by a gate patch that fails one of these
> jobs.

This sounds like a really good idea to me... I suspect rechecking
ancient checks is still a good idea, but a pre-gate check would
decrease the worth of ancient rechecks a lot.

Michael

-- 
Rackspace Australia