Open Stack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This is great, Steve, thanks!

Let's stick with what's in the code.

L

On 22/07/15 05:53, Steve Gordon wrote:
> ----- Original Message -----
>> From: "Matt Kassawara" <mkassawara at gmail.com> To: "Atsushi SAKAI"
>> <sakaia at jp.fujitsu.com>
>> 
>> We should call these "weight" or "weights" to agree with every
>> other technical thing that uses this concept.
> 
> Aren't these configuration values based on the literal strings
> actually used in the code? E.g. (note that weighter appears to be a
> typo introduced in the docs, scheduler_default_weighters doesn't
> exist anywhere as a configuration key in the source code:
> 
> sgordon at localhost:~/Source/cinder(master)> grep -r GoodnessWeighter
> * sgordon at localhost:~/Source/cinder(master)> grep -r
> GoodnessWeigher * 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:class
> GoodnessWeigherTestCase(test.TestCase): 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> super(GoodnessWeigherTestCase, self).setUp() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/tests/unit/scheduler/test_goodness_weigher.py:
> weigher = goodness.GoodnessWeigher() 
> cinder/scheduler/weights/goodness.py:class
> GoodnessWeigher(weights.BaseHostWeigher): setup.cfg:
> GoodnessWeigher =
> cinder.scheduler.weights.goodness:GoodnessWeigher
> 
> sgordon at localhost:~/Source/cinder(master)> grep -r
> "scheduler_default_weighters" * -r 
> sgordon at localhost:~/Source/cinder(master)> grep -r
> "scheduler_default_weighers" * -r 
> cinder/tests/unit/scheduler/test_scheduler.py:        #
> scheduler_default_filters and scheduler_default_weighers when 
> cinder/tests/unit/scheduler/test_scheduler.py:
> scheduler_default_weighers=['CapacityWeigher']) 
> cinder/tests/unit/scheduler/test_scheduler.py:
> self.assertEqual(CONF.scheduler_default_weighers, 
> cinder/tests/unit/scheduler/test_scheduler.py:
> scheduler_default_weighers=['CapacityWeigher']) 
> cinder/tests/unit/scheduler/test_scheduler.py:
> self.assertEqual(CONF.scheduler_default_weighers, 
> cinder/scheduler/simple.py:  scheduler_default_weighers =
> 'ChanceWeigher' cinder/scheduler/simple.py:
> scheduler_default_weighers = 'AllocatedCapacityWeigher' 
> cinder/scheduler/host_manager.py:
> cfg.ListOpt('scheduler_default_weighers', 
> cinder/scheduler/host_manager.py:
> CONF.set_override('scheduler_default_weighers', 
> cinder/scheduler/host_manager.py:
> CONF.set_override('scheduler_default_weighers', 
> cinder/scheduler/host_manager.py:        it uses
> CONF.scheduler_default_weighers instead. 
> cinder/scheduler/host_manager.py:            weight_cls_names =
> CONF.scheduler_default_weighers
> 
>> On Tue, Jul 21, 2015 at 12:34 AM, Atsushi SAKAI
>> <sakaia at jp.fujitsu.com> wrote:
>> 
>>> Hello
>>> 
>>> I am looking around following document and find same two
>>> keywords are used on the document. Which word
>>> (weigher/weighter) is correct for this case?
>>> 
>>> for example GoodnessWeigher VolumeNumberWeigher
>>> scheduler_default_weighters
>>> 
>>> OpenStack Cloud Administrator Guide 
>>> http://docs.openstack.org/draft/admin-guide-cloud-rst/
>>> 
>>> Thanks Atsushi SAKAI
>>> 
>>> 
>>> _______________________________________________ OpenStack-docs
>>> mailing list OpenStack-docs at lists.openstack.org 
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs
>>>
>>
>>
>>> 
_______________________________________________
>> OpenStack-docs mailing list OpenStack-docs at lists.openstack.org 
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs
>>
>
>> 
- -- 
Lana Brindley
Technical Writer
Rackspace Cloud Builders Australia
http://lanabrindley.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVrrn6AAoJELppzVb4+KUy67QIAKsbJyAr3kH9+esSRu9OYniF
5RDG2Pnecolv+SEjv+lU8I0l2kiI3hqzxw9G/pFOVf4YIxFYMqlHVOjwMqQ3zHcU
R3gnTKpC+0vSGI56Ydl6NVB6FPjEp8vD+9ih0poIv7UtFhLyuEeZlZBMmUTg5tv0
TWfFs+0ij8sLZUbniza9X6W7BWHStYG5g/p4yKTs9xzRi/BjqGzdL9NH3pha4lJX
5qzuVHBhsUSZskh2L7ttpEe+ujOLVeHteQjhrCczMQyqnH5BKUnI5mkVh3zhWDbf
sYrwaSeb3yHgvAX1+pUXw3Is7J2zW8JbISNhKGY8x1PVJZSFOOny7Ys56XpyJ54=
=wXjK
-----END PGP SIGNATURE-----