Open Stack

On 05/26/2014 07:44 AM, Nick Chase wrote:
> OK, so here's where we are:
> 
> I've got one patch in that does the wholesale conversion to XML, but
> doesn't have things broken down and audited yet. That's here:
> 
> https://review.openstack.org/#/c/95401/
> 
> However, as you can see, it doesn't pass tox.  It doesn't pass tox
> locally because it's trying to convert it to docbook, and there's
> nothing to convert.  I've removed that functionality from os-docs-tools
> here:
> 
> https://review.openstack.org/#/c/95406/
> 
> But that needs to be merged before I can run tox on the book to look for
> other problems.  I think.

Agreed. I should have read my whole INBOX before patching and answering ;)

> Anyway, I've just commented code here; I'm happy to actually delete it
> if I've done the right thing, but I didn't want to just hack out a bunch
> of code without someone more familiar looking at it first.

You commented out too much in that file and missed the parts that
actually builds the books, I've updated your patch.

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126