[Openstack-docs] openstack-doc-tools needs some changes

Łukasz Jernaś deejay1 at srem.org
Sun Feb 9 13:21:08 UTC 2014


On Sun, Feb 9, 2014 at 2:07 PM, Andreas Jaeger <aj at suse.com> wrote:
> On 02/09/2014 11:24 AM, Andreas Jaeger wrote:
>> On 02/09/2014 10:13 AM, Łukasz Jernaś wrote:
>>> On Sat, Feb 8, 2014 at 6:58 PM, Andreas Jaeger <aj at suse.com> wrote:
>>>> generatedocbook and generatepot are used from tox.ini and need to be in
>>>> usr/bin. If you have a proposal for new names, please send it. We can
>>>> change those but need to do it carefully so that we do not break the
>>>> gates. I would do it in a few steps - first step add a new name and
>>>> leave the old as link, get it in, then change all files that use it to
>>>> use the new name and then remove the old names.
>>>
>>> I think these two should be merged into os_doc_tools, there's nothing
>>> specific in them to keep them as separate scripts.
>>
>> We need to call them from tox.ini.
>>
>> So, what exactly do you want to propose? Move to os_doc_tools and add
>> them to setup.cfg as entry points?
>>
>> Patches are welcome - I happily abandon my change
>> https://review.openstack.org/#/c/72135/ for a better solution - or
>> improve from there,
>
> I've merged the two scripts now into one - there was a lot of
> duplication - and amended my patch:
> https://review.openstack.org/#/c/72135/
>
> Łukasz, is this what you had in mind?

Yes, almost exactly what I had on my mind, I was only thinking about
having them as commands to one of the other entry points, but that
will work.

Thanks Andreas!
-- 
Łukasz [DeeJay1] Jernaś



More information about the Openstack-docs mailing list