[OpenStack-docs] [training-guides] Criteria for core reviewership

Pančur, Matjaž Matjaz.Pancur at fri.uni-lj.si
Sun Dec 14 14:22:26 UTC 2014


+1 for 2x +2 

I believe that enforcing this rule for all (except really trivial) patches will also:
- strengthen our review process and 
- enhance team collaboration

Matjaz

> On 14. dec. 2014, at 08.21, Roger Luethi <rl at patchworkscience.org> wrote:
> 
> On Sat, 13 Dec 2014 11:11:42 -0600, Anne Gentle wrote:
>> Oh definitely can +2 your own patches early on and with small teams. I
>> still do so for API docs. It has only been this last year or so where I've
>> gotten to the point where I get two others to +2 my patches in
>> openstack-manuals.
> 
> In that case requiring 2x +2 for non-trivial patches would formalize what
> we've been doing pretty much since the repo existed. Fine, let's do it.
> 
> Thanks for the explanations, Anne.
> 
> Roger
> 
> _______________________________________________
> OpenStack-docs mailing list
> OpenStack-docs at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs




More information about the OpenStack-docs mailing list