Open Stack

On 09/12/2013 09:16 PM, Steve Gordon wrote:
> ----- Original Message -----
>> From: "Andreas Jaeger" <jaegerandi at gmail.com>
>> To: sgordon at redhat.com
>> Sent: Thursday, September 12, 2013 2:59:52 PM
>> Subject: Re: Change in openstack/openstack-manuals[master]: Fixed repeated "and" in IBM Storwize Driver content.
>>
>> See commit 31743bb1d5c90723624e8fb4dcc3cf0b7618a2e7 - I run a check some
>> days ago and picked up duplicates. This needs to be done regularly ;(
>>
>> Thanks,
>> Andreas
> 
> Right, at the bootcamp earlier in the week those of us present talked about possibly expanding the validation checks and splitting out into multiple jobs (some voting, some non-voting). A repeated words check definitely looks like it's one of the jobs we could/should consider :).
> 
> My check is pretty basic (dumb) and as a result picks up some erroneous results though so couldn't be voting, e.g.:
> 
> $ for file in `find . -name *.xml`; do grep -Pro '\s+(\w+)\s+\1\s+' $file; done


I used egrep:

 egrep -r '\b(\w+)\b \1 ' *xml

And yes, visual inspection of the result was needed.

> [...]


> What does your check look like? Either way if we could add one of
> these as a non-voting validation check that would be a start (I am
> working back through the jenkins-job-builder tutorial working out
> how to go about doing this :)).

have a look at https://review.openstack.org/#/c/42157/, this can be
used as basis for adding these kind of checks.

Andreas

P.S. Steve, sorry for the duplicate, I noticed to late that you did a
list reply.
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126