[Openstack-docs] [openstack/nova] DocImpact review request change Ie69aa2621cb52d6fefdc19f664247b069d6782ee
gerrit2 at review.openstack.org
gerrit2 at review.openstack.org
Wed Jul 24 15:59:09 UTC 2013
Hi, I'd like you to take a look at this patch for potential
DocImpact.
https://review.openstack.org/35303
Log:
commit abca73c23942c4533449dff2242dd8314e9879f4
Author: Phil Day <philip.day at hp.com>
Date: Tue Jul 2 15:32:57 2013 +0100
Stop and delete operations should give guest a chance to shutdown
Currently in libvirt stop and delete operations simply destroy the
underlying VM. Some GuestOS's do not react well to this type of
power failure, and so it would be better if these operations
followed the same approach as soft_reboot and give the guest as
chance to shutdown gracefully. Even where VM is being deleted,
it may be booted from a volume which will be reused on another
server.
The change is implemented by adding a clean_shutdown parameter
to delete and stop methods from the compute/api layer downwards
and into the virt drivers. The implementation in the libvirt
driver is also provided. Other drivers are modified just to
expect the additional parameter.
The timer configuration value previous used by soft_reboot in
libvirt is moved up to virt/driver so it can be used by other drivers.
A separate config value defines what the default shutdown
behaviour for delete should be (default False to keep compatibility
with current behaviour).
This code enables a subsequent API change to add add clean/forced
options to the stop and delete methods
Fixes bug 1196924
DocImpact
Change-Id: Ie69aa2621cb52d6fefdc19f664247b069d6782ee
Automatically generated bug (please review):
https://bugs.launchpad.net/bugs/1204566
More information about the Openstack-docs
mailing list