[Openstack-docs] [openstack/nova] DocImpact review request change Ic41d138a1ee4cdaf785e45091bd5668045153b90

gerrit2 at review.openstack.org gerrit2 at review.openstack.org
Tue Nov 20 23:17:35 UTC 2012


Hi, I'd like you to take a look at this patch for potential
DocImpact.
https://review.openstack.org/16595

Log:
commit 95db2478b0a10f0128c23e6f609eaf9b6230d457
Author: Chris Behrens <cbehrens at codestud.com>
Date:   Tue Nov 20 21:17:29 2012 +0000

    Rename sql_pool_size to sql_max_pool_size
    
    A recent patch adds a sql_pool_size config option.  This renames it to
    sql_max_pool_size and sets a default that equals SQLAlchemy's default
    (5).
    
    eventlet's db_pool allows setting a minimum size, so this is to prep for
    adding a sql_min_pool_size... and remove some confusion.
    
    No need to support sql_pool_size for backwards compatibility as it
    was to be a new option in Grizzly, anyway.
    
    Also fixes the previous patch to not set pool options if using
    StaticPool or NullPool.
    
    DocImpact
    
    Change-Id: Ic41d138a1ee4cdaf785e45091bd5668045153b90




More information about the Openstack-docs mailing list