<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-2">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
You can already do this with the kolla image builder which seems to me to be a much better solution than patching containers post creation. </div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Michal Arbet <michal.arbet@ultimum.io><br>
<b>Sent:</b> 23 May 2023 13:01<br>
<b>To:</b> openstack-discuss@lists.openstack.org <openstack-discuss@lists.openstack.org><br>
<b>Subject:</b> Re: [kolla] How to patch images during build</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div class="x_mc-ip-hide">
<div style="color:#000000; font-size:12px; text-align:left; font-family:Helvetica,Arial,sans-serif">
<strong><br>
<div class="x_caution" style="background-color:#F47F53; font-family:sans-serif"><span style="font-size:14pt"><strong>CAUTION:</strong></span>
<span style="font-size:11pt; font-weight:400">This email originates from outside THG</span>
</div>
</strong><br>
</div>
<hr>
</div>
I am very glad that someone asked for an option to patch kolla images.
<div>I've already proposed patches for kolla here [1] and here [2]. </div>
<div>But unfortunately I didn't get that many votes to merge into master and I abandoned this.</div>
<div><br>
</div>
<div>[1] <a href="https://review.opendev.org/c/openstack/kolla/+/829296">https://review.opendev.org/c/openstack/kolla/+/829296</a></div>
<div>[2] <a href="https://review.opendev.org/c/openstack/kolla/+/829295">https://review.opendev.org/c/openstack/kolla/+/829295</a></div>
<div><br>
</div>
<div>With these above patches you can patch files inside every container.</div>
<div>Maybe we can discuss this again ??</div>
<div><br>
</div>
<div>For example now xena, yoga, zed, antelope has oslo.messaging broken :</div>
<div><br>
</div>
<div><a href="https://bugs.launchpad.net/oslo.messaging/+bug/2019978">https://bugs.launchpad.net/oslo.messaging/+bug/2019978</a><br>
</div>
<div>fixed by</div>
<div><a href="https://review.opendev.org/c/openstack/oslo.messaging/+/866617">https://review.opendev.org/c/openstack/oslo.messaging/+/866617</a><br>
</div>
<div><br>
</div>
<div>As I am using my kolla patches in my downstream kolla git repo i've only created patches/ directory and place fix for openstack-base container :)</div>
<div><br>
</div>
<div>patches/<br>
patches/openstack-base<br>
patches/openstack-base/series<br>
patches/openstack-base/fix-rabbitmq-issue-opendev-883538.patch<br>
</div>
<div><br>
</div>
<div>But, you still can use template-override <a href="https://docs.openstack.org/kolla/latest/admin/image-building.html">https://docs.openstack.org/kolla/latest/admin/image-building.html</a> .</div>
<div><br>
</div>
<div>Thanks</div>
<div><br>
</div>
<div>
<div>
<div>
<div dir="ltr" class="x_gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div style="margin:0px; padding:0px 0px 20px; width:1503px; color:rgb(34,34,34); font-family:Roboto,RobotoDraft,Helvetica,Arial,sans-serif; font-size:medium">
<div style="margin:8px 0px 0px; padding:0px">
<div dir="ltr"><span>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr" style="font-family:Arial,Helvetica,sans-serif; font-size:small"><span style="color:rgb(136,136,136); vertical-align:top; line-height:18px; font-size:11pt; font-family:Arial,Helvetica,Geneva; font-weight:bold">Michal Arbet<br>
</span><span style="color:rgb(136,136,136); font-size:10pt; vertical-align:top; line-height:18px; font-family:Arial,Helvetica,Geneva">Openstack Engineer<br>
<img width="200" height="81" src="https://www.google.com/a/ultimum.io/images/logo.gif"><br>
Ultimum Technologies a.s.<br>
Na Poříčí 1047/26, 11000 Praha 1<br>
Czech Republic<br>
<br>
<a value="+420608314961" style="color:rgb(17,85,204)">+420 604 228 897</a> <br>
<a href="mailto:michal.arbet@ultimum.io" target="_blank" style="color:rgb(17,85,204)">michal.arbet@ultimum.io</a><br>
</span><font color="#1155cc" face="Arial, Helvetica, Geneva" style="font-size:12.8px"><span style="font-size:13.3333px; line-height:18px"><u><a href="https://ultimum.io/" target="_blank" style="color:rgb(17,85,204)">https://ultimum.io</a></u></span></font><br>
</div>
<div dir="ltr" style="font-family:Arial,Helvetica,sans-serif; font-size:small"><font color="#1155cc" face="Arial, Helvetica, Geneva" style="font-size:12.8px"><span style="font-size:13.3333px; line-height:18px"><br>
</span></font></div>
<div style="font-family:Arial,Helvetica,sans-serif; font-size:small"><font color="#666666"><a href="https://www.linkedin.com/company/ultimum-technologies" target="_blank" style="color:rgb(17,85,204)">LinkedIn</a> | <a href="https://twitter.com/ultimumtech" target="_blank" style="color:rgb(17,85,204)">Twitter</a> | <a href="https://www.facebook.com/ultimumtechnologies/timeline" target="_blank" style="color:rgb(17,85,204)">Facebook</a></font></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</span></div>
</div>
<div>
<div></div>
<div>
<div></div>
</div>
</div>
<div></div>
</div>
</div>
</div>
</div>
<br>
</div>
</div>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">st 17. 5. 2023 v 20:19 odesílatel Jeremy Stanley <<a href="mailto:fungi@yuggoth.org">fungi@yuggoth.org</a>> napsal:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
On 2023-05-17 21:02:02 +0300 (+0300), Maksim Malchuk wrote:<br>
> Yes, you can do that, but note bene mitaka not supported.<br>
[...]<br>
<br>
Not only unsupported, but the stable/mitaka branch of<br>
openstack/keystone was deleted when it reached EOL in 2017. You may<br>
instead want to specify `reference = mitaka-eol` (assuming Git tags<br>
also work there). That should get you the final state of the<br>
stable/mitaka branch prior to its deletion.<br>
-- <br>
Jeremy Stanley<br>
</blockquote>
</div>
</div>
</body>
</html>