<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
PS: tox issues have been fixed in master branch of Ansible OpenStack
collection, please rebase your patches :)<br>
<br>
<div class="moz-cite-prefix">On 27.12.22 11:40, Jakob Meng wrote:<br>
</div>
<blockquote type="cite"
cite="mid:93eb35c5-2f88-b119-a8d7-26d0b3d5a7b2@redhat.com"> Hello
Gaël,<br>
thank you for giving us feedback on our Ansible modules and
actually submitting a new module ☺️ We are currently lagging a bit
in responses because we are trying to get release 2.0.0 of the
Ansible OpenStack collection out of the door in January 2023.<br>
<br>
As part of this effort we also refactored our CI integration
tests, it is more consistent nowadays but still not complete. With
compute_service_info you picked our worst case, it is tested in
role nova_services 😬 A relict from the past.<br>
<br>
Initially we planned to write one Ansible role per module, e.g.
role project_info for openstack.cloud.project_info. But doing so
produced a lot of redundant code. So during this year we changed
our plan. Now we merge tests for *_info modules with their
non-info equivalents. For example, tests for both modules
federation_mapping and federation_mapping_info can be found in
role federation_mapping.<br>
<br>
Integration tests for volume_service_info would be located in
Ansible role volume_service.<br>
<br>
Instead of compute_service_info better take
neutron_rbac_policies_info as an example of how to write and test
*_info modules. Refactoring compute_service_info is still on my
todo list 😅 Same goes for our docs on how to write modules etc.
🙈<br>
<br>
Best,<br>
Jakob <br>
<br>
<div class="moz-cite-prefix">On 27.12.22 00:11, Gaël THEROND
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CABNe=UuOR-0v_3LeT9gtiuAVxGWkztGgytRpLHX1_p11FXfAYQ@mail.gmail.com">
<div dir="auto">Hi sadi,</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thanks for this feedback!</div>
<div dir="auto">I’ll wait for this patch to be merged then, no
biggies as it’s currently greetings season’s so no rush xD</div>
<div dir="auto"><br>
</div>
<div dir="auto">I’ll probably have few patches after that
especially around unifying options (filtering especially) on
few modules.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thanks for the answer!</div>
<div><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Le lun. 26 déc. 2022 à
21:06, Sagi Shnaidman <<a
href="mailto:sshnaidm@redhat.com"
class="moz-txt-link-freetext" moz-do-not-send="true">sshnaidm@redhat.com</a>>
a écrit :<br>
</div>
<blockquote class="gmail_quote">
<div dir="ltr">
<div>Hi, Gael,</div>
<div><br>
</div>
<div>Thanks for your contribution! Currently the
tox-2.12 CI job always fails, it's because of tox
version 4 changes. I add a workaround in the patch <a
href="https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868607"
target="_blank" class="moz-txt-link-freetext"
moz-do-not-send="true">https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868607</a>
<br>
</div>
<div>When it (or other solution) is merged, you're good
to go with your patch. Sorry for the inconvenience .</div>
<div><br>
</div>
<div>Thanks<br>
</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Dec 24, 2022
at 4:22 PM Gaël THEROND <<a
href="mailto:gael.therond@bitswalk.com"
target="_blank" class="moz-txt-link-freetext"
moz-do-not-send="true">gael.therond@bitswalk.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote">Hi ansible collections
openstack team!
<div><br>
</div>
<div dir="auto">I finally had time to list all my
issues met with the project, created few bug reports
and even contributed to a patch today (minor, mainly
copy/paste) however I’ve few questions regarding the
CI process!</div>
<div dir="auto"><br>
</div>
<div dir="auto">Overall, what’s the rule with the CI
code testing?</div>
<div dir="auto">I’ve read the contributing guide and
had an eye on previous patches to see how it’s used
but I’m having a hard time to find a real unified
method. For instance, it seems that some module miss
CI tasks (such as compute_service_info) or did I
missed something?</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thanks a lot for all the good job!</div>
</blockquote>
</div>
<br>
<br>
-- <br>
<div dir="ltr">
<div dir="ltr">
<div>Best regards<br>
</div>
Sagi Shnaidman<br>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>