Open Stack

On Wed, 2022-06-15 at 01:04 +0100, Sean Mooney wrote:
> On Wed, 2022-06-15 at 00:58 +0100, Sean Mooney wrote:
> > On Tue, 2022-06-14 at 18:49 -0500, Ghanshyam Mann wrote:
> > >  ---- On Tue, 14 Jun 2022 17:47:59 -0500 Thomas Goirand <zigo at debian.org> wrote ----
> > >  > On 6/13/22 00:10, Thomas Goirand wrote:
> > >  > > Hi,
> > >  > > 
> > >  > > A few DDs are pushing me to upgrade jsonschema in Debian Unstable. 
> > >  > > However, OpenStack global requirements are still stuck at 3.2.0. Is 
> > >  > > there any reason for it, or should we attempt to upgrade to 4.6.0?
> > >  > > 
> > >  > > I'd really appreciate if someone (else than me) was driving this...
> > >  > > 
> > >  > > Cheers,
> > >  > > 
> > >  > > Thomas Goirand (zigo)
> > >  > > 
> > >  > 
> > >  > FYI, Nova fails with it:
> > >  > https://ci.debian.net/data/autopkgtest/unstable/amd64/n/nova/22676760/log.gz
> > >  > 
> > >  > Can someone from the Nova team investigate?
> > > 
> > > Nova failures are due to the error message change (it happens regularly and they change them in most versions)
> > > in jsonschema new version. I remember we faced this type of issue previously also and we updated
> > > nova tests not to assert the error message but seems like there are a few left which is failing with
> > > jsonschema 4.6.0.
> > > 
> > > Along with these error message failures fixes and using the latest jsonschema, in nova, we use
> > > Draft4Validator from jsonschema and the latest validator is Draft7Validator so we should check
> > > what are backward-incompatible changes in Draft7Validator and bump this too?
> > 
> > well i think the reason this is on 3.2.0 iis nothing to do with nova
> > i bumpt it manually in https://review.opendev.org/c/openstack/requirements/+/845859/
> > 
> > The conflict is caused by:
> >     The user requested jsonschema===4.0.1
> >     tripleo-common 16.4.0 depends on jsonschema>=3.2.0
> >     rsd-lib 1.2.0 depends on jsonschema>=2.6.0
> >     taskflow 4.7.0 depends on jsonschema>=3.2.0
> >     zvmcloudconnector 1.4.1 depends on jsonschema>=2.3.0
> >     os-net-config 15.2.0 depends on jsonschema>=3.2.0
> >     task-core 0.2.1 depends on jsonschema>=3.2.0
> >     python-zaqarclient 2.3.0 depends on jsonschema>=2.6.0
> >     warlock 1.3.3 depends on jsonschema<4 and >=0.7
> > 
> > https://zuul.opendev.org/t/openstack/build/06ed295bb8244c16b48e2698c1049be9
> > 
> > it looks like warlock is clamping it ot less then 4 which is why we are stokc on 3.2.0
> glance client seams to be the only real user of this
> https://codesearch.opendev.org/?q=warlock&i=nope&literal=nope&files=&excludeFiles=&repos=
> perhaps we could jsut remove the dependcy?

I've proposed vendoring this dependency in glanceclient [1]. I've also proposed
a change to fix this in warlock [2] but given the lack of activity there, I
doubt it'll merge anytime soon so the former sounds like a better option.

Cheers,
Stephen

[1] https://review.opendev.org/c/openstack/python-glanceclient/+/846197
[2] https://github.com/bcwaldon/warlock/pull/65

> > 
> > > 
> > > -gmann
> > > 
> > >  > 
> > >  > Cheers,
> > >  > 
> > >  > Thomas Goirand (zigo)
> > >  > 
> > >  > 
> > > 
> > 
> 
>