[ansible][ACO] - Contribution questions

Gaël THEROND gael.therond at bitswalk.com
Mon Dec 26 23:11:27 UTC 2022


Hi sadi,

Thanks for this feedback!
I’ll wait for this patch to be merged then, no biggies as it’s currently
greetings season’s so no rush xD

I’ll probably have few patches after that especially around unifying
options (filtering especially) on few modules.

Thanks for the answer!

Le lun. 26 déc. 2022 à 21:06, Sagi Shnaidman <sshnaidm at redhat.com> a écrit :

> Hi,  Gael,
>
> Thanks for your contribution! Currently the tox-2.12 CI job always fails,
> it's because of tox version 4 changes. I add a workaround in the patch
> https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868607
> When it (or other solution) is merged, you're good to go with your patch.
> Sorry for the inconvenience .
>
> Thanks
>
>
> On Sat, Dec 24, 2022 at 4:22 PM Gaël THEROND <gael.therond at bitswalk.com>
> wrote:
>
>> Hi ansible collections openstack team!
>>
>> I finally had time to list all my issues met with the project, created
>> few bug reports and even contributed to a patch today (minor, mainly
>> copy/paste) however I’ve few questions regarding the CI process!
>>
>> Overall, what’s the rule with the CI code testing?
>> I’ve read the contributing guide and had an eye on previous patches to
>> see how it’s used but I’m having a hard time to find a real unified method.
>> For instance, it seems that some module miss CI tasks (such as
>> compute_service_info) or did I missed something?
>>
>> Thanks a lot for all the good job!
>>
>
>
> --
> Best regards
> Sagi Shnaidman
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.openstack.org/pipermail/openstack-discuss/attachments/20221227/56ca0fd4/attachment-0001.htm>


More information about the openstack-discuss mailing list