[neutron][devstack][qa] Dropping lib/neutron module

Ghanshyam Mann gmann at ghanshyammann.com
Mon Dec 12 19:40:15 UTC 2022


 ---- On Mon, 28 Nov 2022 03:23:53 -0800  Slawek Kaplonski  wrote --- 
 > Hi,
 > 
 > As You maybe know (or not as this was very long time ago) there are 2 modules to deploy Neutron in devstack:
 > * old one called lib/neutron-legacy
 > * new one called lib/neutron
 > 
 > The problem is that new module lib/neutron was really never finished and used widely and still everyone is using (and should use) old one lib/neutron-legacy.
 > We discussed that few times during PTGs and we finally decided to drop "new" module lib/neutron and have then rename old "lib/neutron-legacy" to be "lib/neutron" again.
 > Decision was made because old module works fine and do its job, and as there is nobody who would like to finish really new module. Also having 2 modules from which "legacy" one is the only one which really works can be confusing and we want to avoid that confusion.
 > 
 > So I proposed patches [1] and [2] to drop this unfinished module. I also proposed DNM patches for Neutron [3] and Tempest [4] to test that all jobs will work fine. But if You are maybe relaying on the Neutron modules from Devstack, please propose some test patch in Your project too and check if everything works fine for You.
 > 
 > In patch [2] I didn't really removed "lib/neutron-legacy" yet because there are some projects which are sourcing that file in their devstack module. As [1] and [2] will be merged I will be proposing patches to change that for those projects but any help with that is welcome :)

Thanks, Slawek to clean up this.

Instead of removing lib/neutron and renaming lib/neutorn-legacy in two separate steps/patches,
should not we do it in a single patch so that 1. project using lib/neutron (like octavia[1]) does not
need any change 2. project using lib/neutron-legacy and lib/neutron both[2] does not need to
change it twice (if 865015 takes time to merge and they need to remove lib/neutron usage first)?

[1] https://opendev.org/openstack/octavia/src/commit/8d27bdb5462474dafc934d164f3a299bfca8dd89/devstack/upgrade/shutdown.sh#L13

[2] https://opendev.org/openstack/networking-generic-switch/src/commit/0ecd02aaa036311c67671717562db956bbc810aa/devstack/upgrade/upgrade.sh#L45-L46

-gmann

 > 
 > [1] https://review.opendev.org/c/openstack/devstack/+/865014
 > [2] https://review.opendev.org/c/openstack/devstack/+/865015
 > [3] https://review.opendev.org/c/openstack/neutron/+/865822
 > [4] https://review.opendev.org/c/openstack/tempest/+/865821 
 > 
 > -- 
 > Slawek Kaplonski
 > Principal Software Engineer
 > Red Hat
 > 



More information about the openstack-discuss mailing list