Open Stack

Hi all,

I've been working on
https://review.opendev.org/c/openstack/tripleo-heat-templates/+/816895 and the
current pep8 check error on the designate-api-container-puppet.yaml template
appears to disallow using different container config images on the same config
volume.

I see where this makes sense but because the way the puppet_config sections
seem to be structured I wonder if it was intentional. The templates happen to
work in this patch's case because the api specific config image in this
template only includes some additional binaries for apache+wsgi necessary for
the puppet. However, I can see where this might cause some really unfortunate
issues if the config images for a given config_volume were to have different
versions of puppet.

While I will alter the templates so the designate config volume use the
same config image, it does beg the question if having the puppet_config
config_volume definitions duplicated across the templates is a good
pattern.  Would it be a better choice to adopt a pattern where the
immutable parts of the config_volumes (e.g. config_volume name,
config_image) can only be defined once per config volume? Perhaps in a
separate file and have the mutable parts in their respective template
definitions?

Cheer,

Brent

--
Brent Eagles
Principal Software Engineer
Red Hat Inc.