Open Stack

 ---- On Thu, 18 Nov 2021 10:24:31 -0600 Jeremy Stanley <fungi at yuggoth.org> wrote ----
 > On 2021-11-18 08:15:06 -0800 (-0800), Dan Smith wrote:
 > [...]
 > > Absolutely agree, humans are not good at making these decisions.
 > > Despite "trust" in the core team, and even using a less-loaded
 > > word than "abuse," I really don't think that even allowing the
 > > option to override flaky tests by force merge is the right
 > > solution (at all).
 > [...]
 > 
 > Just about any time we Gerrit admins have decided to bypass testing
 > to merge some change (and to be clear, we really don't like to if we
 > can avoid it), we introduce a new test-breaking bug we then need to
 > troubleshoot and fix. It's a humbling reminder that even though you
 > may feel absolutely sure something's safe to merge without passing
 > tests, you're probably wrong.

Indeed. I too agree here and it can lead to the situation that 'hey my patch was all good
can you just +W this' which can end up more unstable tests/code.

-gmann

 > -- 
 > Jeremy Stanley
 >