[oslo] fix flake8-hacking inconsistences on xena/wallaby
hberaud at redhat.com
Tue Mar 23 11:00:42 UTC 2021
As you surely recently observed patches proposed by the openstack bot to
configure wallaby fail with a flake8/hacking issue.
Here are some guideline to fix the problem the inconsistency:
- Patch pre-commit on master (now xena) (here is the patch:
- Once Xena is patched cherry-pick and backport these changes on Wallaby
- Rebase the openstack bot patches on the top of this cherry-pick (or wait
for the merge of the previous one patch)
You can copy the patch on oslo.db with the related commit message .
The root cause of the issue was that with the introduction of pre-commit we
started to define the version of flake8 to use. Previously this version was
defined by hacking's requirements.
Indeed a few months ago we added pre-commit to allow us to run checks with
git hooks and reduce the usage of our gates. These changes were
standardized and spread on all the scope of oslo .
However, during the design of these changes  and after some discussion
we decided to pin the version of flake8 to use, hence by doing this we
short circuited hacking on its management of flake8.
The solution to solve this issue is simply to trust hacking on its flake8
management. Hacking will pull the right version of flake8 and the
inconsistency will disappear. flake8 provides a pre-commit hook so it could
be seen and called as a local target.
Senior Software Engineer at Red Hat
-----BEGIN PGP SIGNATURE-----
-----END PGP SIGNATURE-----
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the openstack-discuss