[Cinder] Review pretty please

Mike Carden mike.carden at gmail.com
Fri Mar 19 06:20:24 UTC 2021

I'm not a Cinder dev, but I could not help looking at this suggested
change. To me at least, it's an insta-merge, but I think it might get
overlooked because the Commit Message doesn't detail "What you would now
see" versus "What you should see", and the cognitive load on reviewers is
high enough that it gets ignored.

+1 from someone who has no right to say so.


On Fri, Mar 19, 2021 at 3:43 PM Sam Morrison <sorrison at gmail.com> wrote:

> Hi Cinder cores,
> I've had a simple review [1] waiting for several months, could I please
> get some feedback on this.
> Thanks!
> Sam
> [1] https://review.opendev.org/c/openstack/cinder/+/764875
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20210319/87f9b37f/attachment-0001.html>

More information about the openstack-discuss mailing list