[all] CI test result table in the new gerrit review UI
smooney at redhat.com
Tue Jan 19 12:56:41 UTC 2021
On Tue, 2021-01-19 at 12:37 +0100, Dmitry Tantsur wrote:
> On Tue, Jan 19, 2021 at 7:01 AM Ian Wienand <iwienand at redhat.com> wrote:
> > On Thu, Nov 26, 2020 at 01:39:13PM +0100, BalÃƒÂ¡zs Gibizer wrote:
> > > I understand that adapting the old CI test result table to the new gerrit
> > > review UI is not a simple task.
> > We got there in the end :) Change  enabled the zuul-summary-results
> > plugin, which is available from . I just restarted opendev gerrit
> > with it, and it seems to be working. Look for the new "Zuul Summary"
> > tab next to "Files". I would consider it a 0.1 release and welcome
> > any contributions to make it better.
> Thank you, this is amazing! I wonder if we could also run the plugin that
> shows the live progress (it was mentioned somewhere in the thread).
i belive showing the live progress of the jobs is effectivly a ddos vector.
in our browser in the past.
providing a link to the running zuul objs that are not actively pooling might be nice at least for the 1st party ci.
there might be a way for 3rd party ci to post a link to the builds or something for there results.
my concern would still remain though with anything that does active pooling ddosing the zuul api.
i know that we previously tried enbeding the zuul job status directly into gerrit a few years ago and that had to be qickly
reverted as it does not take many developers leave review open in a tab to quickly make that unworkable.
i know i for one often leave review open over night if im pinged to review something shortly before i finish for the
day so that its open on my screen when i log in the next day. if that tab was activly pooling ci jobs that would be an issue
if many people did it. if it was just as static liknk on the other hand to the job build it would not have the same downside.
so i guess it depend on if you want live updates of the running jobs or just a one of server side generated static
link to the running job that you can click though to look at its console output.
the latter might be nice but i am not sure the former is a good idea for the reason i mentioned.
> > If you want to make changes, you should be able to submit a change to
> > system-config with a Depends-On: and trigger the
> > system-config-run-review test; in the results returned there are
> > screenshot artifacts that will show the results (expanding this
> > testing also welcome!). We can also a put a node on hold for you to
> > work on the plugin if you have interest. It's also fairly easy to run
> > the container locally, so there's plenty of options.
> > Thanks,
> > -i
> >  https://review.opendev.org/c/opendev/system-config/+/767079
> > 
> > https://gerrit-review.googlesource.com/admin/repos/plugins/zuul-results-summary
More information about the openstack-discuss