[cinder] Review of tiny patch to add Ceph RBD fast-diff to cinder-backup

Brian Rosmaita rosmaita.fossdev at gmail.com
Wed Apr 7 12:28:51 UTC 2021


On 4/7/21 7:53 AM, Christian Rohmann wrote:
> On 13/01/2021 10:37, Christian Rohmann wrote:
>> I wrote a tiny patch to add the Ceph RDB feature of fast-diff to 
>> backups created by cinder-backup:
>>
>>  * https://review.opendev.org/c/openstack/cinder/+/766856/
>>
>>
>> Could someone please take a peek and let me know of this is sufficient 
>> to be merged? 
> 
> 
> This change was already merged to master and I now created cherry-picks 
> / backports to victoria 
> (https://review.opendev.org/c/openstack/cinder/+/782917) and ussuri 
> (https://review.opendev.org/c/openstack/cinder/+/782929).
> Also Andrey Bolgov did create yet another backport of this feaure down 
> to stable/train (https://review.opendev.org/c/openstack/cinder/+/784041).
> 
> While the cherry-pick onto the stable/victoria branch does verify fine 
> with Zuul (only need review to be merged), the 
> cinder-plugin-ceph-tempest tests fail for ussuri and also train.
> 
>> Stdout: 'RBD image feature set mismatch. You can disable features unsupported by the kernel with "rbd feature disable volumes/volume-081e9c22-21f3-4585-a2fe-1caed098052b object-map fast-diff".\nIn some cases useful info is found in syslog - try "dmesg | tail".\n'
>> Stderr: 'rbd: sysfs write failed\nrbd: map failed: (6) No such device or address\n'
> 
> Could anybody give me a hint on why this might be?

You have hit https://bugs.launchpad.net/devstack-plugin-ceph/+bug/1921897

Eric has a patch up addressing this: 
https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/783880

> 
> Also is there any other process to follow for backports than to create a 
> cherry-pick from the following release down and wait for review?
> 

You're following the correct procedure.  One thing I noticed, though, is 
that your pick to stable/ussuri should have the cherry pick info for 
both the cherry-pick from master (which was the wallaby development 
branch at the time) to stable/victoria and also from victoria to 
stable/ussuri.

> 
> 
> Regards
> 
> 
> Christian
> 




More information about the openstack-discuss mailing list