Open Stack

I agree with Sean in that it is quite dangerous this late in the cycle.
Let's do it early in the Wallaby cycle.

-yoctozepto

On Fri, Sep 4, 2020 at 6:44 PM Herve Beraud <hberaud at redhat.com> wrote:
>
>
>
> Le ven. 4 sept. 2020 à 14:50, Sean McGinnis <sean.mcginnis at gmx.com> a écrit :
>>
>> On 9/4/20 2:44 AM, Herve Beraud wrote:
>> > Hey Oslofolk,
>> >
>> > I request an FFE for these oslo.messaging changes [1].
>> >
>> > The goal of these changes is to run rabbitmq heartbeat in python
>> > thread by default.
>> >
>> > Also these changes deprecating this option to prepare future removal
>> > and force to always run heartbeat in a python thread whatever the context.
>> >
>> > Land these changes during the victoria cycle can help us to prime the
>> > option removal during the next cycle.
>> >
>> > Thanks for your time,
>> >
>> > [1] https://review.opendev.org/#/c/747395/
>> >
>> With the overall non-client library freeze yesterday, this isn't just an
>> Oslo feature freeze request. It is also a release and requirements
>> exception as well.
>
>
> Right, good point.
>
>>
>> The code change itself is very minor. But this flips a default for a
>> behavior that hasn't been given very wide usage and runtime. I would be
>> very cautious about making a change like that right as we are locking
>> down things and trying to stabilize for the final release. It's a nice
>> change, but personally I would feel more comfortable giving it all of
>> the wallaby development cycle running as the new default to make sure
>> there are no unintended side effects.
>
>
> Sure we can survive without these changes until the Wallaby cycle.
>
>>
>> I am interested in hearing Ben's opinion though.
>>
>> Sean
>>
>>
>
>
> --
> Hervé Beraud
> Senior Software Engineer
> Red Hat - Openstack Oslo
> irc: hberaud
> -----BEGIN PGP SIGNATURE-----
>
> wsFcBAABCAAQBQJb4AwCCRAHwXRBNkGNegAALSkQAHrotwCiL3VMwDR0vcja10Q+
> Kf31yCutl5bAlS7tOKpPQ9XN4oC0ZSThyNNFVrg8ail0SczHXsC4rOrsPblgGRN+
> RQLoCm2eO1AkB0ubCYLaq0XqSaO+Uk81QxAPkyPCEGT6SRxXr2lhADK0T86kBnMP
> F8RvGolu3EFjlqCVgeOZaR51PqwUlEhZXZuuNKrWZXg/oRiY4811GmnvzmUhgK5G
> 5+f8mUg74hfjDbR2VhjTeaLKp0PhskjOIKY3vqHXofLuaqFDD+WrAy/NgDGvN22g
> glGfj472T3xyHnUzM8ILgAGSghfzZF5Skj2qEeci9cB6K3Hm3osj+PbvfsXE/7Kw
> m/xtm+FjnaywZEv54uCmVIzQsRIm1qJscu20Qw6Q0UiPpDFqD7O6tWSRKdX11UTZ
> hwVQTMh9AKQDBEh2W9nnFi9kzSSNu4OQ1dRMcYHWfd9BEkccezxHwUM4Xyov5Fe0
> qnbfzTB1tYkjU78loMWFaLa00ftSxP/DtQ//iYVyfVNfcCwfDszXLOqlkvGmY1/Y
> F1ON0ONekDZkGJsDoS6QdiUSn8RZ2mHArGEWMV00EV5DCIbCXRvywXV43ckx8Z+3
> B8qUJhBqJ8RS2F+vTs3DTaXqcktgJ4UkhYC2c1gImcPRyGrK9VY0sCT+1iA+wp/O
> v6rDpkeNksZ9fFSyoY2o
> =ECSj
> -----END PGP SIGNATURE-----
>